Skip to content

fix(navbar): no item position#9007

Open
AugustinMauroy wants to merge 2 commits into
mainfrom
fix-navbar
Open

fix(navbar): no item position#9007
AugustinMauroy wants to merge 2 commits into
mainfrom
fix-navbar

Conversation

@AugustinMauroy

@AugustinMauroy AugustinMauroy commented Jul 14, 2026

Copy link
Copy Markdown
Member

Description

update style and add more stories

Validation

it's should be correct

Related Issues

Close nodejs/doc-kit#882

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner July 14, 2026 14:45
@vercel

vercel Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jul 15, 2026 7:22pm

Request Review

@cursor

cursor Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Presentation-only NavBar and Storybook changes; site usage still passes Logo and nav items as before.

Overview
Fixes navbar layout when the logo or nav links are missing by making Logo optional and only rendering the home link when a logo component is provided.

CSS updates push the mobile menu toggler to the right (ml-auto on the label), hoist .navInteractionIcon so icon sizing still applies, and tweak desktop flex on .main and .actionsWrapper (xl:justify-between, w-full, xl:ml-auto) so actions stay aligned when nav items are empty.

Storybook now uses the real Node.js logo and search modal, and adds NoLogo and NoLogoNoNavItems stories alongside the existing default and no-nav-items cases.

Reviewed by Cursor Bugbot for commit 4c05a40. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.52%. Comparing base (61cd932) to head (4c05a40).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ages/ui-components/src/Containers/NavBar/index.tsx 10.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9007      +/-   ##
==========================================
- Coverage   74.58%   74.52%   -0.07%     
==========================================
  Files         100      100              
  Lines        8801     8803       +2     
  Branches      324      325       +1     
==========================================
- Hits         6564     6560       -4     
- Misses       2233     2239       +6     
  Partials        4        4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 10.70 MB
New Total First Load JS 10.70 MB
Delta 36.00 B (0.00%)

Changes

🔄 Modified Routes (4)
Route Old First Load JS New First Load JS Delta
/[locale] 2.55 MB 2.55 MB 📈 9.00 B (0.00%)
/[locale]/[...path] 2.55 MB 2.55 MB 📈 9.00 B (0.00%)
/[locale]/blog/[...path] 2.55 MB 2.55 MB 📈 9.00 B (0.00%)
/[locale]/download/archive/[version] 2.55 MB 2.55 MB 📈 9.00 B (0.00%)

@avivkeller

avivkeller commented Jul 14, 2026

Copy link
Copy Markdown
Member

(also fyi @nodejs/nodejs-website #9007 (comment), shown above, is the new bundle size diff comment format)

@bmuenzenmeyer

bmuenzenmeyer commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

I am looking at this in chromatic. don't we want this to be pulled to the right?

image

@AugustinMauroy

AugustinMauroy commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

@bmuenzenmeyer fixed

@avivkeller avivkeller requested a review from bmuenzenmeyer July 15, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aymen94 aymen94 aymen94 approved these changes
@avivkeller avivkeller avivkeller approved these changes
@bmuenzenmeyer bmuenzenmeyer Awaiting requested review from bmuenzenmeyer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

navbar: wrong item position

4 participants

@AugustinMauroy @avivkeller @bmuenzenmeyer @aymen94